Init grid parallelisations - #173
Open
wilfchun wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request significantly improves the parallel performance and thread safety of the
nInitGridAndCalcStillWaterLevelfunction insrc/init_grid.cppby redesigning how accumulators are handled in OpenMP parallel regions. The main change is the introduction of cache-aligned, thread-local accumulators to eliminate false sharing and reduce synchronization overhead, resulting in more efficient and scalable parallel execution.Parallelization and performance improvements:
ThreadLocalAccumulatorsstruct and allocated one per thread to prevent false sharing and synchronization bottlenecks during parallel accumulation. This replaces OpenMP reduction clauses with thread-local storage, improving scalability on multi-core systems.Correctness and code clarity:
Minor code cleanup:
pdRasterallocation).