-
Notifications
You must be signed in to change notification settings - Fork 1
issue-2 update template dependencies #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| :url "https://github.com/CoNarrative/precept.git" | ||
| :license {:name "MIT" | ||
| :url "https://github.com/CoNarrative/precept/blob/master/LICENSE"} | ||
| :dependencies [[org.clojure/clojure "1.9.0-alpha15"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably want to bump this to alpha17 to keep in sync with Precept. https://github.com/CoNarrative/precept/blob/45a1912c05d71d79709cc347e9ab53b8fa48f6cb/project.clj#L6
| :dependencies [[org.clojure/clojure "1.9.0-alpha15"] | ||
| [org.clojure/clojurescript "1.9.494"] | ||
| [precept "0.3.0-alpha"] | ||
| [org.clojure/clojurescript "1.9.854"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is the latest and greatest? Probably want to update Precept to this version or replace this with the version Precept is using. The projects in the precept/examples folder will be affected by this too.
|
This is great! Thank you. I'm overwhelmed with adding devtools functionality and other outside work at the moment but will merge this ASAP, hopefully tonight. See comments regarding versions of Clojure, Clojurescript. There are definitely bigger issues and its our fault for not addressing them earlier. I've added an issue to the main precept repo regarding this. |
|
Yeah I imagined this is toward the bottom of your priority list, so no worries or hurries on roping it in. I was also wondering how other frameworks offload manual maintenance given the rapid release of new clojure/script versions. Let me know if you find a comfy solution. One other thing I've been working on in the todomvc example is ensuring that visible-todos stays sorted in the order they were entered. Otherwise they reshuffle to the underlying map representation (this happens at N=9 on my macbook for both chrome and firefox). I was thinking it might be a good thing to leave unsolved in the example, but offer it in the README as a good intro to the framework for newcomers. It's taken me longer than I thought it might, and still not sure what the idiomatic approach would be 🤔 |
|
@nolan330 Very considerate. I think this is critical because anyone starting with the framework is likely to use the template, and if they can't run it that's a horrible introduction. Further, 0.4.0-alpha should include hot reloading. A lot of effort went into that and it's a great feature to have, so we should make sure it's in the template. Maintaining the sort order was a challenge. Would be interested to see what you were able to do. Our approach was to use the by-fact-id accumulator. This sorts by the |
Addresses #2; trivial change to the lein template dependencies