Skip to content

Conversation

@usernolan
Copy link

Addresses #2; trivial change to the lein template dependencies

@usernolan usernolan mentioned this pull request Aug 10, 2017
:url "https://github.com/CoNarrative/precept.git"
:license {:name "MIT"
:url "https://github.com/CoNarrative/precept/blob/master/LICENSE"}
:dependencies [[org.clojure/clojure "1.9.0-alpha15"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want to bump this to alpha17 to keep in sync with Precept. https://github.com/CoNarrative/precept/blob/45a1912c05d71d79709cc347e9ab53b8fa48f6cb/project.clj#L6

:dependencies [[org.clojure/clojure "1.9.0-alpha15"]
[org.clojure/clojurescript "1.9.494"]
[precept "0.3.0-alpha"]
[org.clojure/clojurescript "1.9.854"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is the latest and greatest? Probably want to update Precept to this version or replace this with the version Precept is using. The projects in the precept/examples folder will be affected by this too.

@alex-dixon
Copy link
Contributor

This is great! Thank you. I'm overwhelmed with adding devtools functionality and other outside work at the moment but will merge this ASAP, hopefully tonight. See comments regarding versions of Clojure, Clojurescript. There are definitely bigger issues and its our fault for not addressing them earlier. I've added an issue to the main precept repo regarding this.

@usernolan
Copy link
Author

usernolan commented Aug 12, 2017

Yeah I imagined this is toward the bottom of your priority list, so no worries or hurries on roping it in. I was also wondering how other frameworks offload manual maintenance given the rapid release of new clojure/script versions. Let me know if you find a comfy solution.

One other thing I've been working on in the todomvc example is ensuring that visible-todos stays sorted in the order they were entered. Otherwise they reshuffle to the underlying map representation (this happens at N=9 on my macbook for both chrome and firefox). I was thinking it might be a good thing to leave unsolved in the example, but offer it in the README as a good intro to the framework for newcomers. It's taken me longer than I thought it might, and still not sure what the idiomatic approach would be 🤔

@alex-dixon
Copy link
Contributor

@nolan330 Very considerate. I think this is critical because anyone starting with the framework is likely to use the template, and if they can't run it that's a horrible introduction. Further, 0.4.0-alpha should include hot reloading. A lot of effort went into that and it's a great feature to have, so we should make sure it's in the template.

Maintaining the sort order was a challenge. Would be interested to see what you were able to do. Our approach was to use the by-fact-id accumulator. This sorts by the :t key of the Tuple, which is incremented for each fact added to the session. The result we hoped for was that this would result in a "last modified" sort order. I'll have to revisit the issue to see exactly what's going wrong. I believe the entities macro is involved, and when I checked it last it did seem like it produces a hydrated entity for each eid in the list it receives and maintains the order. Perhaps the problem is elsewhere, not sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants