Skip to content

discard cover-pages for files_dir (search) #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions colrev/packages/files_dir/src/files_dir.py
Original file line number Diff line number Diff line change
Expand Up @@ -547,6 +547,10 @@ def _index_pdf(
self.review_manager.logger.info(f" extract metadata from {file_path}")
try:
if not self.review_manager.settings.is_curated_masterdata_repo():
# TODO : skip cover page
# extract _get_coverpages in colrev/packages/remove_coverpage/src/remove_cover_page.py
# use get_colrev_pdf_id() with custom_page = 1 (for coverpages)

# retrieve_based_on_colrev_pdf_id
colrev_pdf_id = colrev.record.record.Record.get_colrev_pdf_id(
pdf_path=file_path_abs
Expand Down
5 changes: 4 additions & 1 deletion colrev/record/record.py
Original file line number Diff line number Diff line change
Expand Up @@ -616,10 +616,13 @@ def get_colrev_id(
def get_colrev_pdf_id(
cls,
pdf_path: Path,
custom_page: int = 0,
) -> str: # pragma: no cover
"""Generate the colrev_pdf_id"""

return colrev.record.record_identifier.get_colrev_pdf_id(pdf_path)
return colrev.record.record_identifier.get_colrev_pdf_id(
pdf_path, custom_page=custom_page
)

def get_toc_key(self) -> str:
"""Get the record's toc-key"""
Expand Down
9 changes: 6 additions & 3 deletions colrev/record/record_identifier.py
Original file line number Diff line number Diff line change
Expand Up @@ -192,11 +192,12 @@ def get_colrev_id(record: colrev.record.record.Record, *, assume_complete: bool)
return srep


def _get_colrev_pdf_id_cpid2(pdf_path: Path) -> str:
def _get_colrev_pdf_id_cpid2(pdf_path: Path, custom_page: int) -> str:
with tempfile.NamedTemporaryFile(suffix=".png") as temp_file:
file_name = temp_file.name
try:
doc: pymupdf.Document = pymupdf.open(pdf_path)
# TODO : select custom_page
page = next(iter(doc)) # get the first page
pix = page.get_pixmap(dpi=200)
pix.save(file_name) # store image as a PNG
Expand All @@ -214,7 +215,9 @@ def _get_colrev_pdf_id_cpid2(pdf_path: Path) -> str:
raise colrev_exceptions.PDFHashError(path=pdf_path) from exc


def get_colrev_pdf_id(pdf_path: Path, *, cpid_version: str = "cpid2") -> str:
def get_colrev_pdf_id(
pdf_path: Path, *, cpid_version: str = "cpid2", custom_page: int
) -> str:
"""Get the PDF hash"""

pdf_path = pdf_path.resolve()
Expand All @@ -223,7 +226,7 @@ def get_colrev_pdf_id(pdf_path: Path, *, cpid_version: str = "cpid2") -> str:
raise colrev_exceptions.InvalidPDFException(path=pdf_path)

if cpid_version == "cpid2":
return _get_colrev_pdf_id_cpid2(pdf_path)
return _get_colrev_pdf_id_cpid2(pdf_path, custom_page=custom_page)

raise NotImplementedError

Expand Down
Loading