-
-
Notifications
You must be signed in to change notification settings - Fork 107
Remove XNAUI dependency from ClientCore
project and remove DTAConfig
#834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove XNAUI dependency from ClientCore
project and remove DTAConfig
#834
Conversation
c7d9347
to
4e0595f
Compare
4e0595f
to
3b3ba7c
Compare
Nightly build for this pull request:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the XNAUI dependency from the ClientCore
project and refactors the DTAConfig
project by moving its functionality into the main client application. The changes consolidate the architecture by eliminating a separate configuration project and integrating its components directly into DXMainClient
and ClientGUI
.
Key changes:
- Removes the entire
DTAConfig
project and integrates its functionality intoDXMainClient
andClientGUI
- Moves CnCNet-related classes from
ClientCore.CnCNet5
namespace toDTAClient.Domain.Multiplayer.CnCNet
- Relocates embedded resource references from
ClientCore.Resources
toDTAClient.Icons
Reviewed Changes
Copilot reviewed 48 out of 62 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
Directory.Build.props | Removes DTAConfig from the target frameworks condition |
DXClient.sln | Removes the DTAConfig project from the solution |
DTAConfig/DTAConfig.csproj | Deletes the entire DTAConfig project file |
ClientCore/ClientCore.csproj | Removes XNAUI package references and embedded resources |
ClientGUI/ClientGUI.csproj | Adds XNAUI package references moved from ClientCore |
DXMainClient/DXMainClient.csproj | Updates project references and adds embedded resource configuration |
Multiple .cs files | Updates namespace references from ClientCore.CnCNet5 to DTAClient.Domain.Multiplayer.CnCNet and moves settings classes to ClientGUI.Settings |
Comments suppressed due to low confidence (1)
DXMainClient/DXGUI/Generic/ManualUpdateQueryWindow.cs:1
- Duplicate
using ClientCore;
statement should be removed.
using System;
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
using ClientCore.I18N; | ||
using Rampastring.Tools; | ||
using Rampastring.XNAUI; | ||
using Rampastring.XNAUI.XNAControls; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The removed using ClientCore.Extensions;
import may be needed if extension methods are used elsewhere in this file. Verify that all functionality still works without this import.
Copilot uses AI. Check for mistakes.
|
ClientCore
project and refactoring DTAConfig
ClientCore
project and remove DTAConfig
They are generic UI elements extending functionality of XNAUI, so they moved to ClientGUI, but currently used by OptionsWindow only. |
@SadPencil Per my understanding |
Okay, after checking the codes again, indeed, the remaining ones are generic. I have also noticed that |
PR opens #774 that previously was blocked by ClientCore's dependency on XNAUI.