Fix UTF-8 with BOM is introduced in the generated spawnmap.ini file
#738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nightly build for this pull request:
|
SadPencil
force-pushed
the
fix-spawnini-encoding
branch
from
4f5711c to
3085377
Compare
SadPencil
changed the title
spawnmap.ini filespawnmap.ini file
|
@MahBoiDeveloper any comments on this PR? |
MahBoiDeveloper
approved these changes
May 29, 2025
Metadorius
reviewed
May 31, 2025
Metadorius
reviewed
May 31, 2025
Metadorius
reviewed
May 31, 2025
SadPencil
added a commit
to SadPencil/xna-cncnet-client
that referenced
this pull request
Jun 28, 2025
…CnCNet#738) * Fix UTF-8 BOM is introduced in the generated spawnmap.ini file * Provide UTF-8 without BOM encoding into EncodingExt class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cause of this bug:
spawnmap.inifile is written in the same encoding withmapIni.EncodingEncoding.GetEncoding("UTF-8")will return UTF-8 with BOMThis PR can be regarded as a partial revert of the last UDE PR #704:
spawnmap.iniencoding getting messed up #704)In other words, this PR revert the last UDE PR to the original behavior, unless it's a TS game and the UDE is confident and the detected encoding is an encoding that the original client won't correctly handle