-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature of random loading screen support #211
base: develop
Are you sure you want to change the base?
Conversation
35c018b
to
aac69b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of rolling random every time in cycle better just determine a maximum number and roll random one time when breaking.
14d1d14
to
28a495f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes are good but there are a bit more issues to fix.
Code updated. @Metadorius |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nitpick, I'll test meanwhile and merge.
@SadPencil do you have a Discord? Since you are contributing actively lately would be good to use some form of messaging to stay in touch. If you do - hit me up (Kerbiter#3128). |
The code's fine and the idea is solid, but I think ideally something like this should be implemented in |
This PR add a new feature, where the client starts, it choose one file as the loading screen randomly, of the following picture files:
loadingscreen.png
loadingscreen0.png
loadingscreen1.png
loadingscreen2.png
The random code here obeys uniform distribution.There is no breaking change in this PR.