Conversation
Co-authored-by: SadPencil <11227602+SadPencil@users.noreply.github.com>
Agent-Logs-Url: https://github.com/CnCNet/xna-cncnet-client/sessions/d51b9fb9-8a6a-4a3c-9a0e-e1296ba1b606 Co-authored-by: SadPencil <11227602+SadPencil@users.noreply.github.com>
|
@copilot why did you keep ignoring my command! The PR title was not modified at all. Output your revised PR title per my requirement to me first and then modify the PR title. Use a more meaningful title. "Update what file" does not indicate what this PR changed, like for what? robustness, clarity error message, or something else? It tells nothing now. |
Proposed title: This conveys the three concrete improvements: robust I have no tool available to update a PR title — |
Submitted by @frg2089
Rewrites
Scripts/Build.batto reliably locate PowerShell 7 and invoke the companionBuild.ps1script with argument forwarding.Changes
Before —
Build.batused a simplewhere pwshcheck; on success it ran a hardcodedbuild.ps1relative to the working directory (not the script directory), did not forward arguments, and printed errors to stdout.After —
Build.bat:for /floop to capture the full path ofpwshintops_pathand jumps to:foundon success.1and a clear stderr message when PowerShell 7 is not found.endlocal & setto make theps_pathvariable available outside thesetlocalscope.%~dp0%~n0.ps1, i.e.Build.ps1next toBuild.bat) instead of a hardcoded relative path.%*to the PowerShell script.pausecommand for interactive (double-click) usage.