Fix: query-watchdog: avoid issues on heap allocation failing #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coverity is moaning either due to slight code rearangement or new version/settings.
Having de-allocation in the reverse order compared to allocation seems to make gcc-12 static analysis of dynamic-memory-management happy.
wenningerk
force-pushed
the
coverity_issues
branch
from
cfcba33 to
48c9a11
Compare
kgaillot
reviewed
Feb 6, 2023
| free(s_node); | ||
| free(s_mbox); | ||
| free(s_header); |
There was a problem hiding this comment.
Allocation is done header, mbox and then node - so doing it the opposite direction here ...
There was a problem hiding this comment.
... at least that far the theory why it seemed to be more pleased with what I changed around line 560. It actually never complained about this here and iirc at some point it even stopped complaining about the stuff around 560. Had the impression it was some kind of tuning when they brought gcc into fedora. Just to avoid it next time ;-)
wenningerk
changed the title
|
test this please |
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Jun 20, 2023
https://build.opensuse.org/request/show/1093863 by user yan_gao + dimstar_suse - Update to version 1.5.2+20230316.5ec38cf: - query-watchdog: avoid issues on heap allocation failing (gh#ClusterLabs/sbd#147) - Update to version 1.5.2+20230109.cf5c220 (v1.5.2): (forwarded request 1093862 from yan_gao)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
coverity is moaning either due to slight code rearangement
or new version/settings.