Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation improvements #2900

Merged
merged 4 commits into from
Oct 6, 2022
Merged

Documentation improvements #2900

merged 4 commits into from
Oct 6, 2022

Conversation

kgaillot
Copy link
Contributor

@kgaillot kgaillot commented Oct 5, 2022

Overhaul the "Pacemaker Explained" resource class section, and clarify pointer arguments in functions in libcrmcommon's acl.c and xml.c.

@kgaillot
Copy link
Contributor Author

kgaillot commented Oct 5, 2022

@nrwahl2 , and here's the last pointer argument PR for a long while

@kgaillot
Copy link
Contributor Author

kgaillot commented Oct 5, 2022

Only CI failure is a test infrastructure issue on rhel90z-s390x

Copy link
Contributor

@nrwahl2 nrwahl2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

lib/common/xml.c Outdated Show resolved Hide resolved
doc/sphinx/Pacemaker_Explained/resources.rst Show resolved Hide resolved
Mark pointer arguments as const where appropriate, and ensure doxygen blocks
use [in] or [in,out] as appropriate.

This is not comprehensive but focuses on functions that have doxygen blocks
and some functions called by them, in acl.c and xml.c.
@kgaillot kgaillot merged commit 32e1741 into ClusterLabs:main Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants