Dev: ui_node: Enable standby and maintenance on pacemaker remote node #1855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liangxin1300
force-pushed
the
20250703_standby_remote
branch
2 times, most recently
from
72969e2 to
fd88dd3
Compare
And refactor xmlutil.CrmMonXmlParser.get_node_list function
liangxin1300
force-pushed
the
20250703_standby_remote
branch
3 times, most recently
from
d2f4985 to
0563566
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
liangxin1300
changed the title
liangxin1300
force-pushed
the
20250703_standby_remote
branch
from
0563566 to
966aae2
Compare
It's enough to check the node type is remote, since the remote node's id and uname might be different with the value of RA parameter "server".
It's enough to get the online list of pacemaker remote nodes
liangxin1300
force-pushed
the
20250703_standby_remote
branch
from
a7770f6 to
6667f6d
Compare
| """ | ||
| instance = cls(peer) |
There was a problem hiding this comment.
Why do you change this to a classmethod and create new instance in the method? This does not make sense.
crmsh/xmlutil.py
Outdated
| conditions.append(f'@online="{online_value}"') | ||
| if standby is not None: | ||
| standby_value = 'true' if standby else 'false' | ||
| conditions.append(f'@standby="{standby_value}"') |
There was a problem hiding this comment.
This is to complex. online vs standby, and only_member vs only_remote is mutually exclusive. Please use enum or str instead of bool.
| @@ -3249,7 +3250,8 @@ def __bool__(self): | |||
|
|
|||
| def validate_and_get_reachable_nodes( | |||
| nodes: typing.List[str] = [], | |||
| all_nodes: bool = False | |||
| all_nodes: bool = False, | |||
There was a problem hiding this comment.
Why not test all_nodes at the very beginning in this function? If all_node is true, you don't need to do the other complex logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems
Might have problem:
Changes:
crm_mon --output-as=xmllooks more accurately