Skip to content

Add count argument to semaphore #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 28, 2020
Merged

Add count argument to semaphore #310

merged 5 commits into from
May 28, 2020

Conversation

Slids
Copy link
Contributor

@Slids Slids commented May 11, 2020

The make-semaphore function in ccl doesn't have a count argument.
This whenever someone makes a semaphore, they have to call signal
n times to get a positive count.
Count is a field on new_semaphore so just use it...

The make-semaphore function in ccl doesn't have a count argument.
This whenever someone makes a semaphore, they have to call signal
n times to get a positive count.
Count is a field on new_semaphore so just use it...
@phoe
Copy link
Contributor

phoe commented May 11, 2020

Fixes #308 Actually it doesn't - this adds just a constructor parameter.

Copy link
Contributor Author

@Slids Slids left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make count required

@Slids Slids requested a review from xrme May 17, 2020 22:44
@xrme xrme merged commit 73982ae into Clozure:master May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants