Improvements focused on memory reporting. #796
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjusted Type16 settings (ECC, MaximumCapacity, minimum slots) only for the MacPro71, without affecting other models. Configured MacPro71-specific Type17 logic: reading memory type, channel order, width, locators, and slots. DDR4 is displayed for populated slots and only for the MacPro71.
- Translated technical comments from Russian to English in ConfigManager. - Simplified MLB and ROM selection logic by removing redundant branches. - Added fallbacks for RtROM using System UUID if no network card is found. - Cleaned up redundant manual GPU vendor checks in applySettings() in favor of more robust loop-based detection. - Unified code style for Turbo and Graphics injection settings.
One duplicate line and an unused variable were highlighted.
Improved formatting for better readability and comprehension
|
Did the proposed improvements regarding memory settings for MacPro 7,1 SMBIOS work well when tested? |
### 📄 Summary
This PR introduces a set of improvements focused on memory reporting, SMBIOS accuracy, and modern CPU support, with special attention to **MacPro7,1** systems. The changes enhance correctness, compatibility with real hardware behavior, and overall robustness without altering existing stable logic.
### ✨ Key changes
#### 🔹 SMBIOS & Memory
* **Corrected Type 16 (Physical Memory Array) for MacPro7,1:**
* Enabled ECC (`MultiBitECC`).
* Set correct `MaximumCapacity` = 1.5 TB.
* **Improved Type 17 (Memory Device):**
* Proper handling of ECC widths (72/64) for MacPro7,1.
* Corrected device/bank locators and memory type for empty slots.
* Disabled channel interleaving logic where not applicable (MacPro7,1).
* Preserved `trustSMBIOS` behavior.
#### 🔹 CPU Model Detection
* Extended Nehalem-based logic to include **Nehalem-EX**, **Westmere**, and **Westmere-EX**.
* Added support for **Tiger Lake**, **Alder Lake**, **Raptor Lake**, **Meteor Lake**, **Arrow Lake** families.
* **Improved default SMBIOS selection:**
* i9 CPUs → `iMac20,2`.
* Modern desktop CPUs → `MacPro7,1`.
#### 🔹 SMBIOS Type 4 Accuracy
* Correctly set processor family for **Core i9** and **Xeon** based on `BrandString`.
#### 🔹 Graphics Injection Logic
* Fixed GPU injection detection by scanning the full GPU list instead of only the first two entries.
#### 🔹 Code Quality
* Replaced non-English comments with clear English equivalents.
* Minor cleanups and typo fixes (*sucсess* → *success*), no logic changes.
* Improved formatting for better readability and comprehension.
### 🧪 Testing
* Tested manually on real hardware.
* No regressions observed on existing platforms.
* All changes are limited to `rEFIt_UEFI` and preserve existing behavior outside the affected paths.
### 📌 Notes
These changes aim to improve real-world accuracy and compatibility while maintaining Clover’s established behavior model. No risky refactoring or behavioral changes were introduced.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🟢 Pull Request Title
📄 Summary
This PR introduces a set of improvements focused on memory reporting, SMBIOS accuracy, and modern CPU support, with special attention to MacPro7,1 systems. The changes enhance correctness, compatibility with real hardware behavior, and overall robustness without altering existing stable logic.
✨ Key changes
🔹 SMBIOS & Memory
MultiBitECC).MaximumCapacity= 1.5 TB.trustSMBIOSbehavior.🔹 CPU Model Detection
iMac20,2.MacPro7,1.🔹 SMBIOS Type 4 Accuracy
BrandString.🔹 Graphics Injection Logic
🔹 Code Quality
🧪 Testing
rEFIt_UEFIand preserve existing behavior outside the affected paths.📌 Notes
These changes aim to improve real-world accuracy and compatibility while maintaining Clover’s established behavior model. No risky refactoring or behavioral changes were introduced.