[FIX] cloudlet: Add check for Cloudlet completion in getRemainingCloudletLength() #209
+9
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds additional tests to verify the correct behavior of the Cloudlet finalization process. It includes checks for the remaining length of the Cloudlet after completion and ensures that the Cloudlet status is accurately updated.
|
@erfanara thanks for your contribution, I was out for a conference, I'll be busy the rest of the week as well. I'll get back to your patch as soon as possible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #208
Changes Made:
CloudletSchedulerSingleServiceTest.javato assert that the remaining length is 0 for finished cloudlets and that isFinished() returns true.CloudletTest.javato verify initial states of Cloudlet.