Skip to content

Don't remove service files on restart #1835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eliasfalch wants to merge 2 commits into
base: nightly
Choose a base branch
from
Open

Don't remove service files on restart #1835

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0df25ee
Add removeFiles parameter to updateLifecycle method
eliasfalch Jan 8, 2026
b804995
Refactor updateLifecycle calls to simplify parameters
eliasfalch Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion node/impl/src/main/java/eu/cloudnetservice/node/impl/service/defaults/AbstractService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,6 +348,10 @@ public void updateLifecycle(@NonNull ServiceLifeCycle lifeCycle) {
}

protected void updateLifecycle(@NonNull ServiceLifeCycle lifeCycle, boolean switchToDeletedOnStop) {
updateLifecycle(lifeCycle, switchToDeletedOnStop, switchToDeletedOnStop);
}

protected void updateLifecycle(@NonNull ServiceLifeCycle lifeCycle, boolean switchToDeletedOnStop, boolean removeFiles) {
try {
// prevent multiple service updates at the same time
this.lifecycleLock.lock();
Expand Down Expand Up @@ -389,7 +393,9 @@ protected void updateLifecycle(@NonNull ServiceLifeCycle lifeCycle, boolean swit
LOGGER.info(this.i18n.translate("cloudnet-service-post-stop-message", this.serviceReplacement()));
} else if (this.lifeCycle() == ServiceLifeCycle.RUNNING) {
this.stopProcess();
this.doRemoveFilesAfterStop();
if (removeFiles) {
this.doRemoveFilesAfterStop();
}
// reset the service lifecycle to prepared
this.pushServiceInfoSnapshotUpdate(ServiceLifeCycle.PREPARED);
}
Expand Down