Skip to content

feat: add the type definition of file metadata annotation #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025

Conversation

chlins
Copy link
Contributor

@chlins chlins commented Apr 21, 2025

This pull request introduces a new annotation key and its associated metadata structure to enhance file layer annotations. The most important changes include the addition of AnnotationFileMetadata and the definition of the FileMetadata struct to describe file-specific metadata.

Enhancements to file layer annotations:

  • New annotation key added: Introduced org.cnai.model.file.metadata as a new annotation key to specify file metadata in JSON format. [1] [2]
  • Definition of FileMetadata struct: Added a FileMetadata struct in specs-go/v1/annotations.go to define the metadata schema, including file name, permission mode, owner and group IDs, size, modification time, and type flag.
  • Documentation update: Updated docs/annotations.md to document the new annotation key and provide details about the FileMetadata structure.

Closes #44.

Signed-off-by: chlins <chlins.zhang@gmail.com>
@chlins chlins force-pushed the feat/filemeta-annotation branch from 66a0e69 to 8ee4803 Compare April 21, 2025 06:08
Copy link
Contributor

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@BraveY BraveY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@aftersnow aftersnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins merged commit b4b9a24 into CloudNativeAI:main Apr 22, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discuss for .raw Type and Preservation of File Metadata
4 participants