raise exception if not in transaction #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donbobka
force-pushed
the
raise-if-not-transaction
branch
3 times, most recently
from
727cbeb
to
b11872e
Compare
better message add test fix
donbobka
force-pushed
the
raise-if-not-transaction
branch
from
bd43a5d
to
e15bdfd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should we raise exception to avoid incorrect usage of
transaction: true? Another approach will be create transactionCurrent behavior of library: it silently runs
SELECT pg_advisory_xact_lock(...)that without transaction means lock with immediate unlock and then pass execution to block without active advisory lock.