Add disabled parameter to "Delete" tag and evaluate values before parsing #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please also create a merge request to gh-pages branch, extending the documentation (both en and ru versions)? https://github.com/ClosedXML/ClosedXML.Report/blob/gh-pages/docs/en/More-options.md |
Pankraty
reviewed
Jun 28, 2024
Done #359 |
Pankraty
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were faced with the task of making column deletion user-driven. To solve this, we added the
disabledparameter for theDeletetag. Cases in which a column is deleted:delete disabled=nulldelete disabled=""delete disabled="false"(or"false", "no", "no", "not", "null")In other cases, the column will not be deleted.
To make this logic work, it was necessary to change the order of evaluating values and parsing tags, because in the current logic tags are parsed first, and because of this the disabled parameter does not contain custom values at the tag execution stage.