Skip to content

fix: Update all modules and collect software versions with topic channels#34

Merged
beatrizsavinhas merged 12 commits intodevfrom
31-add-topic-versions
Mar 10, 2026
Merged

fix: Update all modules and collect software versions with topic channels#34
beatrizsavinhas merged 12 commits intodevfrom
31-add-topic-versions

Conversation

@beatrizsavinhas
Copy link
Contributor

@beatrizsavinhas beatrizsavinhas commented Mar 5, 2026

Closes #31

Changed

  • Refactored input for multiqc to conform to updated module requirements.

Fixed

  • Updated all nf-core modules with nf-core modules update to implement latest nf-core changes that use the versions topic channel to collect the software versions:

     'nf-core/bcftools/annotate'                                                                                                                                            
     'nf-core/bcftools/filter' 
     'nf-core/bcftools/index'
     'nf-core/bcftools/view' 
     'nf-core/ensemblvep/vep' 
     'nf-core/multiqc'
     'nf-core/svdb/query'
     'nf-core/tabix/tabix'
     'nf-core/untar'
     'nf-core/vcfanno'
    

Removed

  • Removed deprecated ch_versions from subworkflows/local/prepare_references.nf.

@github-actions
Copy link

github-actions bot commented Mar 5, 2026

PR checklist

  • Fill in description of the PR and link to any relevant issues.
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool, follow the pipeline conventions in the contribution docs.
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Mar 5, 2026

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 8eac197

+| ✅ 180 tests passed       |+
#| ❔  14 tests were ignored |#
!| ❗  28 tests had warnings |!
Details

❗ Test warnings:

  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).
  • pipeline_todos - TODO string in README.md: TODO nf-core:
  • pipeline_todos - TODO string in README.md: Include a figure that guides the user through the major workflow steps. Many nf-core
  • pipeline_todos - TODO string in README.md: Fill in short bullet-pointed list of the default steps in the pipeline 2. Present QC for raw reads (MultiQC)
  • pipeline_todos - TODO string in README.md: Describe the minimum required steps to execute the pipeline, e.g. how to prepare samplesheets.
  • pipeline_todos - TODO string in README.md: update the following command to include all required parameters for a minimal example
  • pipeline_todos - TODO string in README.md: Add citation for pipeline after first release. Uncomment lines below and update Zenodo doi and badge at the top of this file.
  • pipeline_todos - TODO string in README.md: Add bibliography of tools and data used in your pipeline
  • pipeline_todos - TODO string in nextflow.config: Specify your pipeline's command line flags
  • pipeline_todos - TODO string in nextflow.config: Optionally, you can add a pipeline-specific nf-core config at https://github.com/nf-core/configs
  • pipeline_todos - TODO string in nextflow.config: Update the field with the details of the contributors to your pipeline. New with Nextflow version 24.10.0
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in nextflow.config: Specify any additional parameters here
  • pipeline_todos - TODO string in usage.md: Add documentation about anything specific to running your pipeline. For general topics, please point to (and add to) the main nf-core website.
  • pipeline_todos - TODO string in output.md: Write this documentation describing your workflow's output
  • pipeline_todos - TODO string in base.config: Check the defaults for all processes
  • pipeline_todos - TODO string in base.config: Customise requirements for specific processes.
  • pipeline_todos - TODO string in test.config: Specify the paths to your test data on nf-core/test-datasets
  • pipeline_todos - TODO string in test.config: Give any required params for the test so that command line flags are not needed
  • pipeline_todos - TODO string in test_full.config: Specify the paths to your full test data ( on nf-core/test-datasets or directly in repositories, e.g. SRA)
  • pipeline_todos - TODO string in test_full.config: Give any required params for the test so that command line flags are not needed
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • schema_description - Ungrouped param in schema: snv_vcf
  • schema_description - Ungrouped param in schema: sv_vcf
  • schema_description - Ungrouped param in schema: custom_extra_files
  • local_component_structure - prepare_references.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 3.5.2
  • Run at 2026-03-10 11:58:43

@beatrizsavinhas
Copy link
Contributor Author

Test

Command: nextflow run . -profile test,docker --outdir results
Result:
image

Software versions are now collected!

@beatrizsavinhas beatrizsavinhas marked this pull request as ready for review March 9, 2026 14:57
@beatrizsavinhas beatrizsavinhas requested a review from a team as a code owner March 9, 2026 14:57
@beatrizsavinhas beatrizsavinhas self-assigned this Mar 9, 2026
Copy link
Contributor

@kristinebilgrav kristinebilgrav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Lots of nf-core module updates. Saw something with FastQC in the multiQC files that I was wondering about. Otherwise looks good! 🌟

@beatrizsavinhas beatrizsavinhas merged commit cddd747 into dev Mar 10, 2026
4 checks passed
@beatrizsavinhas beatrizsavinhas deleted the 31-add-topic-versions branch March 10, 2026 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Software version not collected

2 participants