Repository navigation
Conversation
JoshDreamland
approved these changes
Sep 11, 2026
| void PschBgworkerMain(Datum main_arg pg_attribute_unused()) { | ||
| #ifdef __GLIBC__ | ||
| // Set before any gRPC/Arrow threads are created; cap glibc malloc arenas to reduce virtual memory usage. | ||
| // Set before any gRPC/Arrow threads are created; cap glibc malloc arenas to reduce virtual memory |
Contributor
There was a problem hiding this comment.
how deeply unlike you
Member
Author
There was a problem hiding this comment.
It hurt me, bit tempted to rewrite the comment, but embracing this as a more mechanical PR
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Address the global unsafe-buffer diagnostic suppression and the _PG_init naming exception.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR formats C sources and expands formatting/lint coverage while aligning naming conventions.
Changes:
- Reformats worker, queue, hook, and exporter code.
- Renames configuration identifiers.
- Updates mise, CI, and clang-tidy configuration.
File summaries
| File | Description |
|---|---|
src/worker/bgworker.c |
Formatting updates |
src/queue/shmem.c |
Formatting updates |
src/queue/query_intern.c |
Formatting updates |
src/queue/psch_dsa.c |
Formatting updates |
src/hooks/query_normalize_state.c |
Formatting and pointer-style updates |
src/hooks/hooks.c |
Formatting updates |
src/export/clickhouse_c_impl.c |
Include ordering update |
src/config/guc.c |
Naming and formatting updates |
mise.toml |
Adds C files to format/lint tasks |
.github/workflows/ci.yml |
Adds C files to formatting checks |
.clang-tidy |
Updates naming and diagnostic configuration |
Review details
- Files reviewed: 11/11 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| Checks: > | ||
| -*, | ||
| clang-analyzer-*, | ||
| -clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling, |
Comment on lines
+31
to
+32
| - key: readability-identifier-naming.FunctionIgnoredRegexp | ||
| value: 'pg_stat_ch_.*' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.