Skip to content

Added dfs.client.use.datanode.hostname config option #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

freshertm
Copy link
Contributor

Fixed #65

Added config option dfs.client.use.datanode.hostname support.

@CLAassistant
Copy link

CLAassistant commented Dec 10, 2024

CLA assistant check
All committers have signed the CLA.

@freshertm
Copy link
Contributor Author

@alexey-milovidov
I've added config option support.
Please review the PR. Thanks.

@alexey-milovidov alexey-milovidov self-assigned this Jan 9, 2025
@alexey-milovidov alexey-milovidov merged commit d0ae7d2 into ClickHouse:master Jan 9, 2025
@freshertm freshertm deleted the add_datanode_hostname_option branch January 14, 2025 11:21
@rschu1ze
Copy link
Member

rschu1ze commented Feb 2, 2025

It is neither clear what this PR nor what #65 is about but since HDFS is a community extension of ClickHouse and not supported in production envs (https://clickhouse.com/docs/en/engines/table-engines/integrations/hdfs), it's okay to merge.

@freshertm Consider contributing it back to upstream (though upstream looks completely dead).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dfs.client.use.datanode.hostname have no effect
4 participants