Skip to content

Conversation

@chernser
Copy link
Contributor

@chernser chernser commented Nov 12, 2025

Summary

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

@chernser chernser requested a review from mzitnik November 13, 2025 14:40
Copy link
Collaborator

@mzitnik mzitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we run integration tests after the upgrade of different package versions

@chernser
Copy link
Contributor Author

Good point!

@mshustov
Copy link
Member

mshustov commented Dec 2, 2025

Shouldn't CI run them automatically?

@chernser
Copy link
Contributor Author

chernser commented Dec 2, 2025

@mshustov

yes they should be run automatically. But something was broken and we are working to restore it.
Locally I have working thing but also need to update CI workflow to make it work in CI, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants