Skip to content

Support nuallable values in SchemalessRecordConverter #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

abdelhakimbendjabeur
Copy link
Contributor

@abdelhakimbendjabeur abdelhakimbendjabeur commented Feb 9, 2023

Summary

When sinking data in which some columns are nullable. a NullPointerException occurs on runtime in the SchemalessRecordConverter. This PR introduces a support for such a case.

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

@abdelhakimbendjabeur abdelhakimbendjabeur force-pushed the support-null-values-in-schemalessRecordConverter branch from 7030c46 to 73c8de5 Compare February 10, 2023 10:20
@CLAassistant
Copy link

CLAassistant commented Feb 10, 2023

CLA assistant check
All committers have signed the CLA.

@mzitnik mzitnik merged commit 7dfba7c into ClickHouse:main Feb 10, 2023
@abdelhakimbendjabeur abdelhakimbendjabeur deleted the support-null-values-in-schemalessRecordConverter branch February 10, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants