Skip to content

Conversation

@dangerous1990
Copy link
Contributor

    /**
     * Maps the given <code>ResultSet</code> column label to its
     * <code>ResultSet</code> column index.
     *
     * @param columnLabel the label for the column specified with the SQL AS clause.  If the SQL AS clause was not specified, then the label is the name of the column
     * @return the column index of the given column name
     * @exception SQLException if the <code>ResultSet</code> object
     * does not contain a column labeled <code>columnLabel</code>, a database access error occurs
     *  or this method is called on a closed result set
     */
    int findColumn(String columnLabel) throws SQLException;

Copy link
Contributor

@zhicwu zhicwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change target to develop and add unit tests accordingly?

@zhicwu zhicwu linked an issue Jan 8, 2021 that may be closed by this pull request
@zhicwu zhicwu added this to the 0.2.5 release milestone Jan 8, 2021
@dangerous1990 dangerous1990 changed the base branch from master to develop January 11, 2021 09:31
@dangerous1990
Copy link
Contributor Author

Could you change target to develop and add unit tests accordingly?

done

@zhicwu zhicwu merged commit 785d5f6 into ClickHouse:develop Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

missing implement ResultSet findColumn() method

2 participants