Skip to content

Conversation

@mdonkers
Copy link
Contributor

Not sure if this is wanted / useful for others.

But in our case, we aren't using the full JDBC library, just this class to compress the INSERT queries (because we're doing some batching of records, then push as one batch to a HTTP output stream).

Because of also other buffers, it is useful to know how much data is buffered into the LZ4 compression buffers, preventing having to call flush() regularly.

@CodingFabian
Copy link

@alex-krash sorry for the ping. Any chance you pick up this contribution? Would help us to eliminate a manually patched jar, and potentially beneficial to others

@zhicwu
Copy link
Contributor

zhicwu commented Jan 7, 2021

@alex-krash sorry for the ping. Any chance you pick up this contribution? Would help us to eliminate a manually patched jar, and potentially beneficial to others

Could you change target to develop? I can help to merge the PR and make it part of the upcoming 0.2.5 release.

@zhicwu zhicwu added this to the 0.2.5 release milestone Jan 7, 2021
@mdonkers mdonkers changed the base branch from master to develop January 8, 2021 07:08
@mdonkers
Copy link
Contributor Author

mdonkers commented Jan 8, 2021

Thank you!
I've changed base to develop.

@zhicwu zhicwu merged commit 336d6c1 into ClickHouse:develop Jan 8, 2021
@mdonkers mdonkers deleted the expose-pointer-for-buffer branch January 8, 2021 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants