[client-v2] fixed hasValue to not throw exception#2758
Open
Conversation
Client V2 CoverageCoverage Report
Class Coverage
|
JDBC V2 CoverageCoverage Report
Class Coverage
|
JDBC V1 CoverageCoverage Report
Class Coverage
|
Client V1 CoverageCoverage Report
Class Coverage
|
|
mzitnik
reviewed
Feb 25, 2026
| @Override | ||
| public boolean hasValue(String colName) { | ||
| return hasValue(schema.nameToColumnIndex(colName)); | ||
| try { |
Contributor
There was a problem hiding this comment.
maybe we can add TableSchema hasColumn instead, using try catch
Contributor
Author
There was a problem hiding this comment.
if we have hasColumn then it will be two methods call.
we need something like nameToColumnIndexSafe(), WDYT?
But this I think overloads interface a bit.
returning -1 by schema.nameToColumnIndex() also looks not a java way.
Idea behind exception is that application code should know what number of columns are in the result:
- we let application access schema to check dynamically
- or application knows it upfront
so checking value for missing column look more like a bug in application.
Contributor
There was a problem hiding this comment.
Using an exception has a little bit performance penalty.
Two methods call, are you worried about performance?
In general, we need to specify the expected behavior of our API. I prefer not use exceptions if we can avoid
Contributor
Author
There was a problem hiding this comment.
I expect reading missing column is be a very specific case.
Ok, I'll implement another safe method to return -1 from schema on unknown column
Contributor
Author
There was a problem hiding this comment.
but I agree that logic based on exception is bad
| @Override | ||
| public boolean hasValue(int colIndex) { | ||
| return hasValue(schema.columnIndexToName(colIndex)); | ||
| try { |
Contributor
There was a problem hiding this comment.
maybe we can add TableSchema hasColumn instead, using try catch
mzitnik
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-Fixes issue with hasValue when it throws exception for unknown column
Closes #2755
Checklist
Delete items not relevant to your PR:
Note
Low Risk
Small, localized behavior change limited to
hasValueedge cases (unknown columns/out-of-range indices) plus added test coverage.Overview
Fixes
hasValue()in the v2 client to be non-throwing when callers ask for a column that doesn’t exist.AbstractBinaryFormatReader.hasValue(int)now bounds-checks indices, andhasValue(String)(plusMapBackedRecord.hasValue(int)) catchesNoSuchColumnExceptionand returnsfalseinstead of propagating an error. Adds an integration test covering missing column names/indices and nullable column behavior for both the binary reader andqueryAllrecord path.Written by Cursor Bugbot for commit 05ff371. This will update automatically on new commits. Configure here.