Fix hasValue to handle missing columns gracefully#2756
Closed
utafrali wants to merge 1 commit intoClickHouse:mainfrom
Closed
Fix hasValue to handle missing columns gracefully#2756utafrali wants to merge 1 commit intoClickHouse:mainfrom
utafrali wants to merge 1 commit intoClickHouse:mainfrom
Conversation
…of throwing for missing columns - Add bounds check to hasValue(int colIndex) to return false when colIndex is out of range instead of throwing ArrayIndexOutOfBoundsException - Wrap hasValue(String colName) in try/catch for NoSuchColumnException to return false when column name does not exist instead of propagating the exception - Add unit test testHasValueWithMissingColumns to verify both fixes Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
|
chernser
approved these changes
Feb 24, 2026
Contributor
|
@utafrali please accept CLA |
Author
|
Closing this PR — I'm unable to sign the CLA at this time. Thank you for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The
hasValue()method on GenericRecord would throw exceptions when checking for non-existent columns:hasValue(int colIndex)threwArrayIndexOutOfBoundsExceptionfor out-of-range indiceshasValue(String colName)threwNoSuchColumnExceptionfor unknown column namesSolution
Add defensive checks to return
falseinstead of throwing:NoSuchColumnExceptionThis makes the API more intuitive and allows callers to safely check for column existence without exception handling.
Fixes #2755