Open
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| } else if (value instanceof String) { | ||
| return (T) ((String)value).getBytes(StandardCharsets.UTF_8); | ||
| } else if (value instanceof InetAddress) { | ||
| return (T) ((InetAddress)value).getAddress(); |
There was a problem hiding this comment.
String/InetAddress handling ignores componentType parameter causing type mismatch
Medium Severity
The getPrimitiveArray method ignores the componentType parameter when handling String and InetAddress values, always returning byte[]. This causes a ClassCastException when calling methods like getIntArray(), getFloatArray(), etc. on columns containing String or InetAddress values. The String/InetAddress conversion to byte[] should only occur when componentType equals byte.class.
| } catch (Exception e) { | ||
| throw ExceptionUtils.toSqlState(String.format("Method: getBytes(\"%s\") encountered an exception.", columnLabel), String.format("SQL: [%s]", parentStatement.getLastStatementSql()), e); | ||
| } | ||
| return getBytes(getSchema().nameToColumnIndex(columnLabel)); |
There was a problem hiding this comment.
Missing closed check causes NPE on closed ResultSet
Medium Severity
The refactored getBytes(String columnLabel) method removed the checkClosed() call that existed in the old implementation. It now directly calls getSchema().nameToColumnIndex(columnLabel) before delegating to getBytes(int). Since getSchema() accesses reader.getSchema() and the close() method sets reader = null, calling this method on a closed ResultSet throws a NullPointerException instead of the expected SQLException with "ResultSet is closed" message.
Client V2 CoverageCoverage Report
Class Coverage
|
JDBC V2 CoverageCoverage Report
Class Coverage
|
|
JDBC V1 CoverageCoverage Report
Class Coverage
|
Client V1 CoverageCoverage Report
Class Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PreparedStatement#setBytesused -byte[]encoded asunhex(<hexstring>)that will let write binary stringsResultSet#getBytesused - thenbyte[]of String object will be returned. Note: still not optimal and internally logic will be changed to store strings asbyte[]and create them on demand.Checklist
Delete items not relevant to your PR:
Note
Medium Risk
Changes core value encoding/decoding paths for
byte[]and refactors many reader getters to flow through index-based logic, which could affect type conversions and null/error handling across result parsing.Overview
Adds first-class binary-string handling for
byte[]across the v2 client/JDBC stack.PreparedStatement#setBytesnow serializesbyte[]as a ClickHouseunhex('...')SQL expression via a newJdbcUtils.convertToUnhexExpression()helper.ResultSet#getBytesis updated to read bytes by column index/label through the binary reader, and the client-sideAbstractBinaryFormatReader#getByteArraycan now returnbyte[]not only for arrays but also when the underlying value is aString(UTF-8) orInetAddress(raw address bytes), alongside a broader refactor to route name-based getters through index-based implementations.Integration tests were extended to cover reading IP columns via
getBytes, inserting/retrieving string/fixed-string values usingsetBytes/getBytes, and adjustingtestSetBytessemantics away from treating bytes as anArray(Int8)parameter.Written by Cursor Bugbot for commit 492f659. This will update automatically on new commits. Configure here.