added test to verify that datetime and time can be used for TIME#2733
Merged
added test to verify that datetime and time can be used for TIME#2733
Conversation
Client V2 CoverageCoverage Report
Class Coverage
|
JDBC V2 CoverageCoverage Report
Class Coverage
|
JDBC V1 CoverageCoverage Report
Class Coverage
|
Client V1 CoverageCoverage Report
Class Coverage
|
jdbc-v2/src/test/java/com/clickhouse/jdbc/JdbcDataTypeTests.java
Outdated
Show resolved
Hide resolved
jdbc-v2/src/test/java/com/clickhouse/jdbc/JdbcDataTypeTests.java
Outdated
Show resolved
Hide resolved
jdbc-v2/src/test/java/com/clickhouse/jdbc/JdbcDataTypeTests.java
Outdated
Show resolved
Hide resolved
… for consistent results
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
jdbc-v2/src/test/java/com/clickhouse/jdbc/JdbcDataTypeTests.java
Outdated
Show resolved
Hide resolved
kurnoolsaketh
approved these changes
Feb 4, 2026
kurnoolsaketh
left a comment
kurnoolsaketh
left a comment
There was a problem hiding this comment.
please add 'UTC' to DateTime, then this is good to merge
jdbc-v2/src/test/java/com/clickhouse/jdbc/JdbcDataTypeTests.java
Outdated
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
Delete items not relevant to your PR:
Note
Low Risk
Behavior change is limited to deterministic ordering in
getTypeInfo()plus additional integration coverage; no core query execution or data conversion logic is modified.Overview
Adds an integration test (
testTimeAndDateTimeCompatibleWithJDBCTime) that verifies both legacyDateTime-backed time values and native ClickHouseTime/Time64(25.6+, behindallow_experimental_time_time64_type) can be read viaResultSet#getTime(...)and that associated date/time components match expectations.Aligns
DatabaseMetaDataImpl#getTypeInfo()output with v1 behavior by adding anORDER BY nameto thesystem.data_type_familiesquery, making type metadata ordering deterministic.Written by Cursor Bugbot for commit 9853a0d. This will update automatically on new commits. Configure here.