Conversation
Client V2 CoverageCoverage Report
Class Coverage
|
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the JDBC driver version handling system to properly parse and store major/minor version numbers using bit-shifted integer encoding. The changes address issue #2410 by implementing a new version parsing method that encodes the major version as (major << 16) | minor and uses the patch version as the minor version for JDBC compliance.
- Implemented new
parseVersion()method with bit-shifted encoding for version numbers - Refactored driver version access from public static fields to private fields with getter methods
- Added comprehensive test coverage for version parsing with various version formats
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| jdbc-v2/src/main/java/com/clickhouse/jdbc/Driver.java | Implemented new version parsing logic with bit-shifted encoding and added getter method |
| jdbc-v2/src/test/java/com/clickhouse/jdbc/DriverTest.java | Added comprehensive test cases for version parsing and updated existing version tests |
| jdbc-v2/src/main/java/com/clickhouse/jdbc/metadata/DatabaseMetaDataImpl.java | Updated to use new driver version getter method |
| jdbc-v2/src/main/java/com/clickhouse/jdbc/internal/JdbcConfiguration.java | Updated to use new driver version getter method |
| jdbc-v2/src/main/java/com/clickhouse/jdbc/ConnectionImpl.java | Updated to use new driver version getter method |
| client-v2/src/test/java/com/clickhouse/client/internal/SmallTests.java | Cleaned up test file by removing unused test methods |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
Author
|
/windsurf review |
Member
|
/windsurf-review |
![windsurf-bot[bot]](https://avatars.githubusercontent.com/in/1066231?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Other comments (1)
- jdbc-v2/src/main/java/com/clickhouse/jdbc/Driver.java (171-171) The return value of `parseVersion` is confusing - it returns `[majorVersion, patch]` where `majorVersion` is actually an encoded combination of major and minor versions. This makes the method name misleading and the return value hard to understand. Consider returning a more explicit structure like `[major, minor, patch]` or creating a dedicated version class.
💡 To request another review, post a new comment with "/windsurf-review".
Contributor
Author
|
@mzitnik |
mzitnik
approved these changes
Sep 19, 2025
Contributor
|
I have approved, but please take a look at the windsurf comments |
JDBC V2 CoverageCoverage Report
Class Coverage
|
JDBC V1 CoverageCoverage Report
Class Coverage
|
Client V1 CoverageCoverage Report
Class Coverage
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2410
Checklist
Delete items not relevant to your PR: