Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[client-v2] Remove dependencies on old projects #1933

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions client-v2/docs/dependencies.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
# Module Dependencies

## Abstract
This document describes module dependencies and a reason for their existence. Additionally
the document keeps historical information about the dependencies.

## Dependencies

### 0.7.1-patch1

- `com.clickhouse:clickhouse-data:jar:0.7.1-patch1-SNAPSHOT:compile` - Required for reading custom data types. When client-v1 required classes should be moved to client-v2 module this dependency will be removed.
- `com.clickhouse:clickhouse-client:jar:0.7.1-patch1-SNAPSHOT:compile` - Required because there is an option to use client-v1. Additionally, this dependency is required because a few core classes like `ClickHouseNode` are used in client-v2. When client-v1 is deprecated - all required classes should be moved to client-v2 module and this dependency will be removed.
- `org.slf4j:slf4j-api:jar:2.0.7:compile` - Most commonly used logging frontend.
- `org.apache.commons:commons-compress:jar:1.27.1:compile` - Required for compression.
- `org.lz4:lz4-pure-java:jar:1.8.0:compile` - Required for compression.
- `org.ow2.asm:asm:jar:9.7:compile` - Required for serialization/deserialization.
- `org.apache.httpcomponents.client5:httpclient5:jar:5.3.1:compile` - only HTTP client that is currently supported. In the future it should be an optional dependency when support for different clients will be added. This client also implements async API that might be used in the future.
- `com.fasterxml.jackson.core:jackson-core:jar:2.17.2:compile` - used to safely parse summary from ClickHouse.
- `org.roaringbitmap:RoaringBitmap:jar:0.9.47:compile` - used for serialization/deserialization of aggregate functions. For some reason `clickhouse-data` modules has this dependency as `provided`.
41 changes: 22 additions & 19 deletions client-v2/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,22 @@
<dependencies>
<dependency>
<groupId>${project.parent.groupId}</groupId>
<artifactId>clickhouse-client</artifactId>
<artifactId>clickhouse-data</artifactId>
<version>${revision}</version>
</dependency>

<dependency>
<groupId>org.roaringbitmap</groupId>
<artifactId>RoaringBitmap</artifactId>
<version>${roaring-bitmap.version}</version>
</dependency>

<dependency>
<groupId>${project.parent.groupId}</groupId>
<artifactId>clickhouse-http-client</artifactId>
<artifactId>clickhouse-client</artifactId>
<version>${revision}</version>
</dependency>

<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
Expand All @@ -41,33 +49,38 @@
<artifactId>httpclient5</artifactId>
<version>${apache.httpclient.version}</version>
</dependency>
<dependency>
<groupId>com.github.luben</groupId>
<artifactId>zstd-jni</artifactId>
<optional>true</optional>
</dependency>

<dependency>
<groupId>org.lz4</groupId>
<artifactId>lz4-pure-java</artifactId>
<version>${lz4.version}</version>
</dependency>

<dependency>
<groupId>org.apache.commons</groupId>
<artifactId>commons-compress</artifactId>
<version>${compress.version}</version>
</dependency>

<dependency>
<groupId>org.ow2.asm</groupId>
<artifactId>asm</artifactId>
<version>9.7</version>
</dependency>

<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-core</artifactId>
<version>2.17.2</version>
</dependency>

<!-- Test Dependencies -->
<dependency>
<groupId>${project.parent.groupId}</groupId>
<artifactId>clickhouse-http-client</artifactId>
<version>${revision}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>com.google.code.gson</groupId>
<artifactId>gson</artifactId>
Expand All @@ -81,12 +94,6 @@
<scope>test</scope>
<version>2.17.2</version>
</dependency>
<!-- necessary for Java 9+ -->
<dependency>
<groupId>org.apache.tomcat</groupId>
<artifactId>annotations-api</artifactId>
<scope>provided</scope>
</dependency>

<!-- Test dependencies -->
<dependency>
Expand Down Expand Up @@ -119,18 +126,14 @@
<version>${testng.version}</version>
<scope>test</scope>
</dependency>
<!-- Replace with newer version as soon java 11 is minimal version -->

<dependency>
<groupId>com.github.tomakehurst</groupId>
<artifactId>wiremock-jre8</artifactId>
<version>2.35.2</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.roaringbitmap</groupId>
<artifactId>RoaringBitmap</artifactId>
<scope>test</scope>
</dependency>

</dependencies>

<build>
Expand Down
Loading
Loading