Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[client-v2] Attach TimeZone to a QueryResponse & use TimeZone settings in binary readers #1763

Merged
merged 8 commits into from
Aug 6, 2024
Merged

[client-v2] Attach TimeZone to a QueryResponse & use TimeZone settings in binary readers #1763

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8649357
implemented passing timezone from response to reader
chernser Aug 4, 2024
e1eb107
propagation of timezone settings to request settings
chernser Aug 5, 2024
fae09e1
implemented handling timezones in readers
chernser Aug 5, 2024
e9ef623
fixed passing timezone from old client
chernser Aug 5, 2024
6d2feaa
updated client v2 example
chernser Aug 5, 2024
8f400f4
Merge branch 'main' into feat_clientv2_timezone
chernser Aug 6, 2024
b7db65f
fix after merge
chernser Aug 6, 2024
6c3a81b
Merge branch 'main' into feat_clientv2_timezone
chernser Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
updated client v2 example
  • Loading branch information
@chernser
chernser committed Aug 5, 2024
commit 6d2feaacac5fab425442b29d1c2a7292b120c7bb
3 changes: 2 additions & 1 deletion examples/client-v2/src/main/java/com/clickhouse/examples/client_v2/SimpleReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,8 @@ public void readDataUsingBinaryFormat() {
try (QueryResponse response = client.query(sql).get(3, TimeUnit.SECONDS);) {

// Create a reader to access the data in a convenient way
ClickHouseBinaryFormatReader reader = new RowBinaryWithNamesAndTypesFormatReader(response.getInputStream());
ClickHouseBinaryFormatReader reader = new RowBinaryWithNamesAndTypesFormatReader(response.getInputStream(),
response.getSettings());

while (reader.hasNext()) {
reader.next(); // Read the next record from stream and parse it
Expand Down