Skip to content

ClickHouseConnectionImpl.isValid setSocketTimeout #483

@majorovms

Description

@majorovms

Current method ClickHouseConnectionImpl.isValid has a timeout parameter, that's very good idea.
But this timeout passes to maxExecutionTime handled by Clickhouse and connectionTimeout handled by http client.

                ClickHouseProperties properties = new ClickHouseProperties(this.properties);
                properties.setConnectionTimeout((int) TimeUnit.SECONDS.toMillis(timeout));
                properties.setMaxExecutionTime(timeout);

It seems to be that socketTimeout missed.

                properties.setSocketTimeout((int) TimeUnit.SECONDS.toMillis(timeout));

In case of some network issues method ClickHouseConnectionImpl.isValid can execute for a long time, defined in ClickHouseProperties of connection.
Why setSocketTimeout is missed?

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions