JDBC Connection fails with "Driver class 'org.slf4j.LoggerFactory' not found."

[frankwese]

Describe the bug

In IntelliJ ultimate updated my Clickhouse Datasource from driver version 0.8.2 to 0.8.3
On "Test Connection" the connection fails with this error:

DBMS: ClickHouse (ver. 25.3.2.39)
Case sensitivity: plain=exact, delimited=exact
Driver: ClickHouse JDBC Driver (ver. 0.6.3 (revision: a6a8a22), JDBC4.2)
Driver class 'org.slf4j.LoggerFactory' not found.

Steps to reproduce

1. update the Driver class to version 0.8.2

[Paultagoras]

Hi @frankwese - could you please try the shaded-all jar?

We're going to revisit some of the packaging, but in the meanwhile that should resolve this for you.

[chernser]

Good day, @frankwese!
The problem here is that org.slf4j.LoggerFactory is part of slf4j-api artifact.
If we include it as is inside the package it will conflict with application instance of same artifact what is not good because library should have flexible dependencies.
If we include slf4j-api as shaded library it will cause change of FCN of all API classes and it will be hard to use it with other logging backends so logging will be broken for our library.

Solution here may be having several versions of packaging

• jar with declared dependencies works when application want a full control over dependencies
• jar + all required dependencies (not shaded) - that would work for your case when application doesn't promote own dependencies
• jar + some required dependencies (shaded) - that would work for application using different similar client libraries.
  However there is still a problem with common part libraries like logging, metrics, format processing libraries.

[Paultagoras]

@frankwese This worked with shaded-all (rather than just -all) but leaving this open as we (the team) should discuss packaging