Skip to content

4032 spacing after list items #4058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

dhtclk
Copy link
Collaborator

@dhtclk dhtclk commented Jul 10, 2025

Summary

Addressing simple UI bug that is present on our getting started cloud page, and also documenting the edge case because it can be subtle. Started a known issues doc and linked it in the style guide for future iteration.

@dhtclk dhtclk self-assigned this Jul 10, 2025
@dhtclk dhtclk requested a review from a team as a code owner July 10, 2025 19:00
@dhtclk dhtclk linked an issue Jul 10, 2025 that may be closed by this pull request
Copy link

vercel bot commented Jul 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clickhouse-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2025 9:07pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
clickhouse-docs-jp ⬜️ Ignored (Inspect) Jul 10, 2025 9:07pm
clickhouse-docs-ru ⬜️ Ignored (Inspect) Visit Preview Jul 10, 2025 9:07pm
clickhouse-docs-zh ⬜️ Ignored (Inspect) Visit Preview Jul 10, 2025 9:07pm

@CLAassistant
Copy link

CLAassistant commented Jul 10, 2025

CLA assistant check
All committers have signed the CLA.

@Blargian
Copy link
Member

Blargian commented Jul 10, 2025

@dhtclk This occurs on many other pages in the docs too e.g https://clickhouse.com/docs/faq/operations/production

Screenshot 2025-07-10 at 21 08 34

adding <br/> after the list is more of a work around. We should be able to style the elements https://github.com/ClickHouse/clickhouse-docs/tree/main/src/css so that it's not necessary to add a <br/> afterwards.

I think there is probably some custom styling applied somewhere that has removed the margin at the bottom of the list items.

@Blargian
Copy link
Member

Blargian commented Jul 11, 2025

For the most part looks great. There are some instances where the spacing between the list end and code block looks too much, I think because we still have the <br/> elements in there. Maybe grepping through and removing them now that the styling is fixed will fix?

Screenshot 2025-07-11 at 13 09 26 (https://clickhouse-docs-4s4zjovwx-clickhouse.vercel.app/docs/getting-started/quick-start/cloud)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spacing after list items
3 participants