Skip to content

Conversation

@bduminiuc
Copy link
Contributor

The ColumnEnum<T> can be initialized with std::vector<T> by moving the vector instead of copying.

@CLAassistant
Copy link

CLAassistant commented Sep 14, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@Enmk Enmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, test failures are unrelated.

Client/ClientCase.TracingContext test will be fixed in a separate PR

@Enmk Enmk merged commit 86225ad into ClickHouse:master Sep 14, 2023
@bduminiuc bduminiuc deleted the move_data_enum_column branch September 22, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants