Skip to content

fix: avoid throwing exception in destructor #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: avoid throwing exception in destructor #146

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion clickhouse/base/compressed.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,16 @@ CompressedOutput::CompressedOutput(OutputStream * destination, size_t max_compre
}

CompressedOutput::~CompressedOutput() {
Flush();
try
{
Flush();
}
catch (...)
{
// That means we've failed to flush some data e.g. to the socket,
// but there is nothing we can do at this point (can't bring the socket back),
// and throwing in destructor is really a bad idea.
}
}

size_t CompressedOutput::DoWrite(const void* data, size_t len) {
Expand Down