Skip to content

fix: adjust colors for disabled menu item #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: adjust colors for disabled menu item #619

wants to merge 1 commit into from

Conversation

ariser
Copy link
Collaborator

@ariser ariser commented Jun 18, 2025 •
edited
Loading

  • remove background color for disabled items because it's not required for a menu item
  • use global disabled color instead of component-specific, because the component-specific is bugged in dark theme
    • note: the global disabled color is slighly darker in light theme

we plan to revisit how colors are defined once Gareth is back from his vacation next month

this affects

  • AutoComplete
  • ContextMenu
  • Dropdown
  • SingleSelect
  • MultiSelect
  • CheckboxMultiSelect
before after
dark image image
light image image

@vercel Vercel
Copy link

vercel bot commented Jun 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
click-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 18, 2025 2:50pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoorayimhelping hoorayimhelping Awaiting requested review from hoorayimhelping

@crisalbu crisalbu Awaiting requested review from crisalbu

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ariser