Skip to content

Comments

Use a patched version of nlohmann::json#14

Merged
iskakaushik merged 1 commit intomainfrom
json-localeconv-patch
Jul 9, 2025
Merged

Use a patched version of nlohmann::json#14
iskakaushik merged 1 commit intomainfrom
json-localeconv-patch

Conversation

@iskakaushik
Copy link
Collaborator

No description provided.

@iskakaushik iskakaushik merged commit d9fd33a into main Jul 9, 2025
2 checks passed
@iskakaushik iskakaushik deleted the json-localeconv-patch branch July 9, 2025 21:56
@rschu1ze
Copy link
Member

nlomnann::json is a dependency of ai-sdk-cpp. From the perspective of ClickHouse as the top-level directory, it is a recursive dependency (a dependencies' dependency). Doing so technically discouraged. It would be nicer if nlohmann::json could be moved into its own fork repository, so that directory contrib/ looks like this:

  • ai-sdk-cpp
  • ai-sdk-cpp-cmake
  • nlohmann
  • nlohmann-cmake

Maintaining nlohmann::json in its own fork repository makes it easier to maintain custom patches (like done here) in the long run.

@rschu1ze
Copy link
Member

Note that another copy of nlohmann::json is being imported as a dependency at the moment (ClickHouse/ClickHouse#82881 (comment)). The one here is being renamed to _patched.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants