Skip to content

Fix event_date in system.asynchronous_metric_log#95947

Merged
Algunenano merged 2 commits intoClickHouse:masterfrom
Algunenano:async_metrics_log
Feb 4, 2026
Merged

Fix event_date in system.asynchronous_metric_log#95947
Algunenano merged 2 commits intoClickHouse:masterfrom
Algunenano:async_metrics_log

Conversation

@Algunenano
Copy link
Member

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Fix event_date in system.asynchronous_metric_log

Closes #95924

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Contributor

clickhouse-gh bot commented Feb 4, 2026

Workflow [PR], commit [5a3e6df]

Summary:

job_name test_name status info comment
Stateless tests (amd_binary, old analyzer, s3 storage, DatabaseReplicated, parallel) failure
03822_attach_with_unknown_projection FAIL cidb, issue ISSUE CREATED
Stress test (arm_asan, s3) failure
Logical error: Block structure mismatch in A stream: different number of columns: (STID: 0993-38e6) FAIL cidb, issue ISSUE EXISTS
Stress test (amd_msan) failure
Logical error: Block structure mismatch in A stream: different number of columns: (STID: 0993-38e6) FAIL cidb, issue ISSUE EXISTS
AST fuzzer (amd_ubsan) failure
Logical error: Unexpected return type 'A' of function 'B', should be tuple of two elements (STID: 0250-21bc) FAIL cidb, issue ISSUE EXISTS

@clickhouse-gh clickhouse-gh bot added the pr-bugfix Pull request with bugfix, not backported by default label Feb 4, 2026
@antonio2368 antonio2368 self-assigned this Feb 4, 2026
Copy link
Member

@alexey-milovidov alexey-milovidov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a test.

Do we have any other cases of time to UInt16 casts in the code?

@Algunenano
Copy link
Member Author

Do we have any other cases of time to UInt16 casts in the code?

I have no idea. A quick check with regex shows hundreds to static_cast<UInt16> but I don't see how to automate the check without a compiler infra that gives us the type of the input.

I'll add a test

@Algunenano Algunenano added this pull request to the merge queue Feb 4, 2026
Merged via the queue into ClickHouse:master with commit c74a30a Feb 4, 2026
126 of 131 checks passed
@Algunenano Algunenano deleted the async_metrics_log branch February 4, 2026 22:24
@robot-ch-test-poll3 robot-ch-test-poll3 added pr-synced-to-cloud The PR is synced to the cloud repo pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR labels Feb 4, 2026
robot-ch-test-poll added a commit that referenced this pull request Feb 4, 2026
Cherry pick #95947 to 26.1: Fix event_date in system.asynchronous_metric_log
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Feb 5, 2026
clickhouse-gh bot added a commit that referenced this pull request Feb 5, 2026
Backport #95947 to 26.1: Fix event_date in system.asynchronous_metric_log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-bugfix Pull request with bugfix, not backported by default pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo v26.1-must-backport

Projects

None yet

Development

Successfully merging this pull request may close these issues.

system.asynchronous_metric_log writes 1970-01-01 for event_date after upgrade to 26.1

4 participants