Remove unused columns when rebuilding projection on merge.#93233
Merged
KochetovNicolai merged 1 commit intomasterfrom Jan 2, 2026
Merged
Conversation
Contributor
|
Workflow [PR], commit [928559d] Summary: ❌
|
Collaborator
|
I've also optimized this part (see https://github.com/ClickHouse/ClickHouse/pull/93114/changes#diff-6c14341ca43dbbaef007e622cb9553ef92f4f32d3f0fd8c150ab7567678df545R984) by leveraging the fact that generated blocks always have monotonically increasing part offsets (both in merges and mutations). This allows us to pass only the starting offset to compute and construct the offset column efficiently. |
Member
Author
|
@amosbird thank you! |
Avogar
approved these changes
Dec 30, 2025
This was referenced Jan 2, 2026
Merged
robot-ch-test-poll2
added a commit
that referenced
this pull request
Jan 2, 2026
Cherry pick #93233 to 25.8: Remove unused columns when rebuilding projection on merge.
This was referenced Jan 2, 2026
robot-ch-test-poll2
added a commit
that referenced
this pull request
Jan 2, 2026
Cherry pick #93233 to 25.10: Remove unused columns when rebuilding projection on merge.
This was referenced Jan 2, 2026
robot-ch-test-poll2
added a commit
that referenced
this pull request
Jan 2, 2026
Cherry pick #93233 to 25.11: Remove unused columns when rebuilding projection on merge.
This was referenced Jan 2, 2026
robot-ch-test-poll2
added a commit
that referenced
this pull request
Jan 2, 2026
Cherry pick #93233 to 25.12: Remove unused columns when rebuilding projection on merge.
clickhouse-gh bot
added a commit
that referenced
this pull request
Jan 2, 2026
Backport #93233 to 25.12: Remove unused columns when rebuilding projection on merge.
clickhouse-gh bot
added a commit
that referenced
this pull request
Jan 2, 2026
Backport #93233 to 25.11: Remove unused columns when rebuilding projection on merge.
clickhouse-gh bot
added a commit
that referenced
this pull request
Jan 2, 2026
Backport #93233 to 25.10: Remove unused columns when rebuilding projection on merge.
clickhouse-gh bot
added a commit
that referenced
this pull request
Jan 2, 2026
Backport #93233 to 25.8: Remove unused columns when rebuilding projection on merge.
1 task
| <clickhouse> | ||
| <profiles> | ||
| <default> | ||
| <min_insert_block_size_bytes>1048576</min_insert_block_size_bytes> |
Member
There was a problem hiding this comment.
I don't understand this test - what does it do?
As it fails every time, I will remove it.
robot-clickhouse-ci-1
added a commit
that referenced
this pull request
Jan 23, 2026
Cherry pick #93233 to 25.3: Remove unused columns when rebuilding projection on merge.
25 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Remove unused columns when the projection is rebuilt during the merge. It reduces memory usage and creates fewer temporary parts.
Documentation entry for user-facing changes