-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix distributed subquery max_query_size limitation inconsistency #34078
Fix distributed subquery max_query_size limitation inconsistency #34078
Conversation
2b1d6a9
to
826a532
Compare
I think these failed tests has no relationship with this PR. |
@Mergifyio update |
✅ Branch has been successfully updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add test from PR description
daa992e
to
fb13ffe
Compare
Done. I think the failed tests are not related to this PR. @novikd Would you please take a look? |
84e4e50
to
59b511c
Compare
What should i do next? @alexey-milovidov @novikd The failed tests are not related to this PR. |
ebbd9b5
to
be8d9c7
Compare
@Mergifyio update |
✅ Branch has been successfully updated |
bec31fe
to
c28a9e9
Compare
Sorry, it has a failing test |
c28a9e9
to
895396e
Compare
Thanks a lot, fixed the failed test and run again. @Felixoid PTAL |
I've checked on 21.8, it raises LGTM |
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix distributed subquery max_query_size limitation inconsistency
When insert distributed table under max_query_size limitation:
insert into demo values ('11', 11, 'haha')
sql clause will be rewrite toINSERT INTO default.demo(name, id, dt) VALUES
and send to local node from distributed node. when max_query_size set to 26, distributed node can parse the sql but local node not, because local node received the longer sql.So we only let the initial node to check the max_query_size, secondary node for distributed table do not need to check it.
How to reproduce: