Repository navigation
ClickHouse Cloud: collect the concurrent QPS - #2610
Merged
Merged
Conversation
Run the shared concurrent QPS test from lib/benchmark-common.sh after the main run, and put its result into the JSON. The queries are sent with curl over HTTPS, because all services are benchmarked at the same time from a single machine, and hundreds of concurrent clickhouse-client processes would overload it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
alexey-milovidov
had a problem deploying
to
benchmark-approval
October 16, 2026 00:29 — with
GitHub Actions
Error
|
github seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
The shell version of the test starts several processes and a new TLS connection for every query. With all services tested at the same time from one runner, the runner was the bottleneck: services with fast queries reached only about 3 QPS regardless of the number of replicas, and the highest numbers came from the services that ran last. concurrent-qps.py runs the same test (10 connections, 600 s, the same seeded query order and counting) as threads in one process, each keeping its HTTPS connection open. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
alexey-milovidov
requested a deployment
to
benchmark-approval
October 16, 2026 01:38 — with
GitHub Actions
Waiting
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run the same concurrent QPS test as for other systems (10 connections, 600 s, the seeded query order of
bench_concurrent_qpsinlib/benchmark-common.sh) on ClickHouse Cloud services after the main run, and recordconcurrent_qpsandconcurrent_error_ratioin the results.concurrent-qps.py(new): the test itself, as threads in one Python process (standard library only), each connection keeping its HTTPS connection open. The shared shell version starts several processes and a new TLS connection per query; with all services tested at once from one runner, the runner became the bottleneck (fast services stuck at about 3 QPS regardless of replicas). Same query order and same counting as the shell version;wait_end_of_query=1makes a query that fails partway through return an HTTP error. There is no watchdog, since a Cloud service can't be restarted from here.benchmark.sh: runs it afterrun.sh. The data size stays on the last line.collect-results.sh: puts the two values into the JSON when they are present and not null.Tested
concurrent-qps.pyagainst a local HTTPS server (about 870 QPS from 10 kept-open connections at under half a core; a failing query and a wrong password are counted as errors), and checked that the permutations match the shared ones. The first Cloud run used the shell client; a second run with the new client is in progress. Each service stays up about 10 minutes longer.🤖 Generated with Claude Code