Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rrtmgp-lookup-data artifact #422

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Add rrtmgp-lookup-data artifact #422

merged 2 commits into from
Jan 12, 2024

Conversation

simonbyrne
Copy link
Member

@simonbyrne simonbyrne commented Jan 8, 2024

Purpose

Adds script for creating RRTMGP lookup data tables artifact, and adds this to the package Artifacts.toml.

Fixes #401 (does not deal with test data, as this is not needed for the main project).

To-do

Content


  • I have read and checked the items on the review checklist.

@simonbyrne simonbyrne force-pushed the sb/lookup-artifact branch 3 times, most recently from 859a27b to 597d07a Compare January 8, 2024 22:43
Comment on lines +3 to +4
using Artifacts
lookup_data() = artifact"rrtmgp-lookup-data"
Copy link
Member Author

@simonbyrne simonbyrne Jan 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did this for convenience, but its probably not a good long term interface. May want to look at how ClimaAtmos uses it: https://github.com/CliMA/ClimaAtmos.jl/blob/103bd85ee59db0a9844663e5a2dd3130ebdf9872/src/parameterized_tendencies/radiation/RRTMGPInterface.jl

@simonbyrne simonbyrne enabled auto-merge (rebase) January 10, 2024 17:55
@simonbyrne simonbyrne merged commit 91d7ec7 into main Jan 12, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RRTMGPReferenceData artifact
2 participants