Add rrtmgp-lookup-data artifact #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonbyrne
force-pushed
the
sb/lookup-artifact
branch
3 times, most recently
from
859a27b
to
597d07a
Compare
simonbyrne
commented
Jan 8, 2024
Comment on lines
+3
to
+4
| using Artifacts | ||
| lookup_data() = artifact"rrtmgp-lookup-data" |
There was a problem hiding this comment.
I did this for convenience, but its probably not a good long term interface. May want to look at how ClimaAtmos uses it: https://github.com/CliMA/ClimaAtmos.jl/blob/103bd85ee59db0a9844663e5a2dd3130ebdf9872/src/parameterized_tendencies/radiation/RRTMGPInterface.jl
sriharshakandala
approved these changes
Jan 10, 2024
simonbyrne
force-pushed
the
sb/lookup-artifact
branch
from
597d07a
to
c2d3a05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Adds script for creating RRTMGP lookup data tables artifact, and adds this to the package Artifacts.toml.
Fixes #401 (does not deal with test data, as this is not needed for the main project).
To-do
Content