Fix single-precision relative and absolute errors #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sriharshakandala
force-pushed
the
sk/single_precision_errors
branch
from
53e5976
to
e8a0655
Compare
sriharshakandala
changed the title
szy21
approved these changes
Jan 8, 2024
|
Could you leave a comment in the code where it is different from the fortran RRTMGP? Just to track the difference. |
tapios
reviewed
Jan 8, 2024
sriharshakandala
force-pushed
the
sk/single_precision_errors
branch
from
963f9b3
to
de0186a
Compare
Improve result printout for tests
sriharshakandala
force-pushed
the
sk/single_precision_errors
branch
from
de0186a
to
93254c6
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Tune tolerances in gas optics and RTE solver to reduce absolute and relative errors in single-precision calculations.