Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove splatting #374

Merged
merged 2 commits into from
Jun 25, 2023
Merged

Remove splatting #374

merged 2 commits into from
Jun 25, 2023

Conversation

charleskawczynski
Copy link
Member

@charleskawczynski charleskawczynski commented Jun 25, 2023

This PR removes some splatting / slurping of arguments, which the compiler cannot seem to infer well. Closes #365.

This is a clear improvement based on the benchmarks.

@charleskawczynski
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 25, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 95777f2 into main Jun 25, 2023
@bors bors bot deleted the ck/365 branch June 25, 2023 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot infer splatted args
1 participant