Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distributed ensemble simulations #295

Merged
merged 96 commits into from
Nov 9, 2022
Merged

Conversation

glwagner
Copy link
Member

@glwagner glwagner commented Oct 29, 2022

This PR implements MPI-based DistributedInverseProblem, and supercedes #291 and #294.

@navidcy
Copy link
Collaborator

navidcy commented Nov 1, 2022

Should this

@test length(eki.iteration_summaries) == iterations + 3

be

@test length(eki.iteration_summaries) == iterations + 1

?

@navidcy
Copy link
Collaborator

navidcy commented Nov 1, 2022

Here,

for field_name in keys(fields(model))

the loop is over all model fields (u, v, w, b) but obs don't have w:
observation = SyntheticObservations(data_path, field_names=(:u, :v, :b))

@navidcy
Copy link
Collaborator

navidcy commented Nov 1, 2022

@glwagner have a look at 936f2c3

@navidcy
Copy link
Collaborator

navidcy commented Nov 1, 2022

https://github.com/CliMA/ParameterEstimocean.jl/actions/runs/3372540837/jobs/5596093372#step:6:282

Seems like the try-catch for using NCDatasets doesn't do the job?

Was there always a problem with netcdf + linux x86 or is it only after Julia v1.8 that problems started? Because this looks like it wasn't dealing with any probs...

@glwagner
Copy link
Member Author

glwagner commented Nov 2, 2022

Should this

@test length(eki.iteration_summaries) == iterations + 3

be

@test length(eki.iteration_summaries) == iterations + 1

?

Yeah.

@glwagner
Copy link
Member Author

glwagner commented Nov 2, 2022

https://github.com/CliMA/ParameterEstimocean.jl/actions/runs/3372540837/jobs/5596093372#step:6:282

Seems like the try-catch for using NCDatasets doesn't do the job?

Was there always a problem with netcdf + linux x86 or is it only after Julia v1.8 that problems started? Because this looks like it wasn't dealing with any probs...

I also found that it wasn't sufficient.

@glwagner
Copy link
Member Author

glwagner commented Nov 2, 2022

Was there always a problem with netcdf + linux x86 or is it only after Julia v1.8 that problems started? Because this looks like it wasn't dealing with any probs...

My impression is that problems start with julia 1.8. But I don't know for sure.

@navidcy
Copy link
Collaborator

navidcy commented Nov 2, 2022

@navidcy navidcy self-requested a review November 6, 2022 03:17
Copy link
Collaborator

@navidcy navidcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ready. I'd like to merge CliMA/Oceananigans.jl#2786 first and then use Oceananigans v0.78.1 here.

@navidcy navidcy merged commit f939c72 into main Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants