Tracking pseudotime and interface for PseudoSteppingSchemes #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adelinehillier we're getting [ Info: Testing EnsembleKalmanInversion construcation and basic iteration (Nbatch = 2)...
EnsembleKalmanInversions construction and iteration tests (Nbatch = 2): Error During Test at /Users/gregorywagner/Projects/ParameterEstimocean.jl/test/test_ensemble_kalman_inversion.jl:71
Got exception outside of a @test
PosDefException: matrix is not Hermitian; Cholesky factorization failed.
Stacktrace:
[1] checkpositivedefinite(info::Int64)
@ LinearAlgebra /Users/julia/buildbot/worker/package_macos64/build/usr/share/julia/stdlib/v1.6/LinearAlgebra/src/factorization.jl:18
[2] cholesky!(A::Matrix{Float64}, ::Val{false}; check::Bool)
@ LinearAlgebra /Users/julia/buildbot/worker/package_macos64/build/usr/share/julia/stdlib/v1.6/LinearAlgebra/src/cholesky.jl:282
[3] #cholesky#134
@ /Users/julia/buildbot/worker/package_macos64/build/usr/share/julia/stdlib/v1.6/LinearAlgebra/src/cholesky.jl:378 [inlined]
[4] cholesky (repeats 2 times)
@ /Users/julia/buildbot/worker/package_macos64/build/usr/share/julia/stdlib/v1.6/LinearAlgebra/src/cholesky.jl:378 [inlined]But this PR is supposed to be a refactor which doesn't affect functionality, so I'm not sure what happened. |
Very strange! I'll look into it. |
glwagner
commented
Apr 9, 2022
src/EnsembleKalmanInversions.jl
Outdated
| @@ -139,7 +139,6 @@ function EnsembleKalmanInversion(inverse_problem; | |||
| Xᵢ = unconstrained_parameters | |||
| iteration = 0 | |||
| pseudotime = 0.0 | |||
| pseudo_Δt = 0.0 | |||
There was a problem hiding this comment.
Should we use default 1.0?
There was a problem hiding this comment.
I think 1.0 does make the most sense
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sandreza you might be interested in this.