Conversation
Also, move some methods from `Utils` to `Grids`, as they need types or functions defined in that submodule.
giordano
force-pushed
the
mg/prettysummary
branch
from
9dca880 to
c4fa3a5
Compare
Collaborator
|
Ups, I think I merged by mistake #4992 in this branch 😅 |
giordano
force-pushed
the
mg/prettysummary
branch
from
db79313 to
9e5cb0a
Compare
Collaborator
Author
|
I did some git surgery to revert that 😀 |
simone-silvestri
approved these changes
Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, move some methods from
UtilstoGrids, as they need types or functions defined in that submodule. Ref: CliMA/ClimaOcean.jl#688 (comment) and NumericalEarth/Breeze.jl#195 (comment).I wish I had done this before, but it didn't occur to me that I could just move some methods from
UtilstoGrids😞 However this change should be non-breaking for downstream packages, asprettysummaryis accessible from bothGridsandUtils.Other functions moved around are
periphery_offsetinterior_work_layout(but this is still nominally inUtils, but extended inGrids)longitude_in_same_windowflip_locationget_longitude_verticesget_latitude_verticesget_lat_lon_nodes_and_verticesget_cartesian_nodes_and_verticesbut according to JuliaHub search (I included the links above) they are used exclusively by Oceananigans, among all packages registered in General, so no downstream package should be affected by these moves.