Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(0.92.0) Make RungeKutta3 the default time-stepper for NonhydrostaticModel #3580

Merged
merged 44 commits into from
Sep 29, 2024

Conversation

glwagner
Copy link
Member

@glwagner glwagner commented May 5, 2024

Who's with me?

Copy link
Collaborator

@navidcy navidcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

I'm with you!

@navidcy
Copy link
Collaborator

navidcy commented May 9, 2024

simulation tests take forever? I'll restart them...

@glwagner
Copy link
Member Author

glwagner commented May 9, 2024

simulation tests take forever? I'll restart them...

Huh, I wonder if that's a downside of this change but not sure...

@glwagner
Copy link
Member Author

glwagner commented May 9, 2024

Says they've been runniing for 7h, that can't be the case on main right?

@navidcy
Copy link
Collaborator

navidcy commented May 9, 2024

No, on main all tests are done in O(1h)… :(
But it’s strange.

@glwagner
Copy link
Member Author

glwagner commented May 9, 2024

No, on main all tests are done in O(1h)… :( But it’s strange.

Simulation tests take 14 min normally:

https://buildkite.com/clima/oceananigans/builds/15704#018f5a18-1775-4a66-b63d-d908d95f9713

something fishy

@glwagner glwagner changed the title Make RungeKutta3 the default time-stepper for NonhydrostaticModel (0.92.0) Make RungeKutta3 the default time-stepper for NonhydrostaticModel Sep 21, 2024
@navidcy
Copy link
Collaborator

navidcy commented Sep 24, 2024

hm... the distributed tests are actually failing; they were passing after 1936d62 and I don't see anything that would justify this in the commits that followed..

@glwagner
Copy link
Member Author

glwagner commented Sep 24, 2024

I believe there's some issue with initialization. It doesn't help to rebuild the individual jobs, because the initialization only happens once and the results are cached are re-used within each build. I think somehow we have to start a new build with a new ID.

@navidcy
Copy link
Collaborator

navidcy commented Sep 25, 2024

They passed now :)

@navidcy
Copy link
Collaborator

navidcy commented Sep 26, 2024

@glwagner
Copy link
Member Author

exit status -1 means the agent was lost :-(

@glwagner
Copy link
Member Author

This is failing now: https://buildkite.com/clima/oceananigans/builds/17582#01922b77-d047-4e99-a497-5facd7241c56/19-1087

oh yea this is something to fix

@navidcy
Copy link
Collaborator

navidcy commented Sep 29, 2024

Merge?

@navidcy
Copy link
Collaborator

navidcy commented Sep 29, 2024

I think we should before conflicts arise again ;)

@glwagner
Copy link
Member Author

Ahh, we keep prioritizing other PRs!

@glwagner
Copy link
Member Author

Let's try to prioritize this one and get it in

@glwagner glwagner merged commit 41209a2 into main Sep 29, 2024
46 checks passed
@glwagner glwagner deleted the glw/rk3-default branch September 29, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants