-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(0.92.0) Make RungeKutta3 the default time-stepper for NonhydrostaticModel #3580
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
I'm with you!
simulation tests take forever? I'll restart them... |
Huh, I wonder if that's a downside of this change but not sure... |
Says they've been runniing for 7h, that can't be the case on |
No, on main all tests are done in O(1h)… :( |
Simulation tests take 14 min normally: https://buildkite.com/clima/oceananigans/builds/15704#018f5a18-1775-4a66-b63d-d908d95f9713 something fishy |
hm... the distributed tests are actually failing; they were passing after 1936d62 and I don't see anything that would justify this in the commits that followed.. |
I believe there's some issue with initialization. It doesn't help to rebuild the individual jobs, because the initialization only happens once and the results are cached are re-used within each build. I think somehow we have to start a new build with a new ID. |
They passed now :) |
exit status -1 means the agent was lost :-( |
oh yea this is something to fix |
Merge? |
I think we should before conflicts arise again ;) |
Ahh, we keep prioritizing other PRs! |
Let's try to prioritize this one and get it in |
Who's with me?