DatasetRestoring only via Metadata

[navidcy]

Only allow DatasetRestoring to be constructed via providing Metadata.

Closes #485

[simone-silvestri]

Isn't it convenient not to have to always build the metadata?
Do you think it is too much of a burden to maintain this constructor? I think it is very convenient to have because if we build only with the metadata we have to know exactly the frequency, start date and last date of the metadata.

I vote to keep the constructor with the variable name

[glwagner]

Isn't it convenient not to have to always build the metadata? Do you think it is too much of a burden to maintain this constructor? I think it is very convenient to have because if we build only with the metadata we have to know exactly the frequency, start date and last date of the metadata.

I vote to keep the constructor with the variable name

I see this as important for the user interface. I think we may want users to have metadata explicitly available for any dataset being used during a simulation. I think we need to keep developing features for metadata. So it's not about the "burden of maintaining a constructor", but rather the detrimental effect / loss of clarity to user scripts. Too much convenience has the effect of obscuring how things work.

I could see us putting this back but the thing is that Metadata has been evolving very rapidly over the past few months. This indicates that we have not really figured out a good design for Metadata yet. So I feel we are not at the stage where we can clearly motivate conveniences like this.

[glwagner]

Should the examples be updated, or do they already all use explicit metadata?

[navidcy]

All examples use explicit metadata. I checked.

[codecov]

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 25.52%. Comparing base (09f492f) to head (caa08cb).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
src/DataWrangling/metadata.jl	40.00%	3 Missing ⚠️
src/DataWrangling/restoring.jl	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #486      +/-   ##
==========================================
+ Coverage   25.48%   25.52%   +0.03%     
==========================================
  Files          47       47              
  Lines        2586     2586              
==========================================
+ Hits          659      660       +1     
+ Misses       1927     1926       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[navidcy]

@simone-silvestri this PR deletes the extra DatasetRestoring constructor but adds convenience in Metadata constructor to provide start and end date as you suggested in #485.